… checks

- csv_parser.py: resolve rocm-smi via shutil.which() so TheRock images
  (where tools live in a Python venv, not /opt/rocm/bin/) are detected
  correctly; accept path_resolver to get ROCm version without hardcoding
  /opt/rocm/.info/version; add bounds check in NVIDIA GPU info parser
- rocenv_tool.py: pass path_resolver to CSVParser so version resolution
  uses RocmPathResolver.get_version() for both TheRock and traditional installs
- container_runner.py: replace host-resolved hardcoded amd-smi/rocm-smi
  paths in container exec with PATH-based resolution; add run phase
  environment table showing host vs container installation type, ROCm/CUDA
  root, and version side-by-side (supports apt install and therock layouts)
- docs: document run phase environment table in usage.md and configuration.md

Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>

- Apply docker_env_vars overrides in context; finalize in run_container (AMD)
  from OCI image env, then docker run probe, then /opt/rocm with warning
- Update docs, README, CLI reference, CHANGELOG, and unit tests
- ADR 0001 left out of this commit (untracked)

Made-with: Cursor

…to coketaste/v2-rocm-path

…TH in --additional-context

The --rocm-path flag was an alias for top-level MAD_ROCM_PATH but its
help text implied it could set both host and container paths, risking
confusion when environments differ. Users should set host and container
ROCm roots independently via --additional-context:

  Host:      {"MAD_ROCM_PATH": "/path/to/host/rocm"}
  Container: {"docker_env_vars": {"MAD_ROCM_PATH": "/path/in/container"}}

Also fixes datetime.utcnow() deprecation warnings in mongodb.py
(replaced with datetime.now(timezone.utc)).

Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>

- validators.py: restrict docker_env_vars.MAD_ROCM_PATH to str|None only
  (was allowing int/float, inconsistent with error message)

- rocm_path_resolver.py: always pop MAD_ROCM_PATH from docker_env even
  when None, preventing the key from leaking into docker run env

- rocm_path_resolver.py: add bin/rocm-smi to _CONTAINER_PROBE_SH
  try_root() predicate to match Python-side looks_like_rocm_root()

- container_runner.py: clear ROCM_PATH before finalize_container_rocm_path
  each run so multi-model runs re-resolve per docker_image instead of
  reusing image 1's path for all subsequent images

- csv_parser.py: shlex.quote() the rocm-smi path before shell interpolation;
  only increment num_gpu after successful NVIDIA line parse (git-ignored
  path, committed separately if needed)

- README.md: replace curly/smart quotes with ASCII quotes in bash examples

- CHANGELOG.md: remove stale --rocm-path alias reference (flag was removed);
  remove broken docs/adr/ link

Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>

)

context.py had a conflict in Context.__init__: develop added
detect_local_gpu_arch (for GPU arch auto-detection in full-run mode)
and rocm_path params; the PR branch dropped both in favour of
resolve_host_rocm_path(). Resolution: keep detect_local_gpu_arch
(still referenced by init_build_context) and drop rocm_path (replaced
by the PR's automatic host ROCm path resolution via resolve_host_rocm_path).

Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>

apply_container_rocm_path_overrides() was falling back to host_path
when docker_env_vars.MAD_ROCM_PATH was None or blank, silently mirroring
the host ROCm root into the container — contradicting the documented
"no host mirroring by default" policy.

Fix: after popping the key (always consumed), return None immediately for
None/blank values instead of substituting host_path.

Add test_apply_overrides_null_mad_rocm_path_does_not_mirror_host to
cover None, "", and whitespace-only values.

Resolves Copilot review comment on PR #110.

Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>

The directory was untracked via git rm --cached in c6370bb but never
added to .gitignore, leaving it one accidental "git add ." away from
being re-committed.

Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>